Emit deprecation warning if multiple v1 templates match with a new index #55558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
added
:Data Management/Indices APIs
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
dakrone
reviewed
Apr 22, 2020
There was a problem hiding this comment.
Thanks for changing this @probakowski! Before we merge it could you run a test locally with ESClientYamlTestSuite's method:
@BeforeClass
public static void initializeUseDefaultNumberOfShards() {
useDefaultNumberOfShards = usually();
}Where usually() is changed to false? This will install a global template for all the YAML tests, and I want to make sure there are no tests that are going to fail due to warnings (better to fail now before we cause CI failures)
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
…taCreateIndexService.java Co-Authored-By: Lee Hinman <[email protected]>
|
@dakrone that was good idea, there's plenty of failures. I'll work on fixing them and request review again when done |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/2 |
dakrone
approved these changes
Apr 29, 2020
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Apr 30, 2020
…dex (elastic#55558) * Emit deprecation warning if multiple v1 templates match with a new index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds deprecation warning when multiple v1 templates match with a new index.
This is deprecated because with v2 templates only one template can match and multiple "levels" of settings should be done using component templates.
Relates to #53101